Add batch insert function to LocalIndex #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally `Object.assign` was being used to create a copy of the object. I replaced it in a previous commit with `structuredClone` since the copy was not a deep one. I keps the `Object.assign` call in case the other functionality it offers was relevant, but seeing as `_update` is checked to be `undefined`, there are no properties to keep in the call to assign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch insert would be very useful to us as we use Vectra to prototype RAG solutions and tend to load in a large amount of data at once.
Setup tests using node:assert to avoid modifying dependencies. Provided test cases pass
Also fixed a bug where the
itemsarray on_datawas being passed by reference in the call toObject.assign. This was causing the third test case to fail because any mutation ofthis._update.itemswas also mutatingthis._data.items(see debug repl below).